Juan Hernandez has posted comments on this change.

Change subject: core: Add Kerberos authenticator
......................................................................


Patch Set 16: Code-Review+1

(1 comment)

....................................................
File backend/manager/modules/authentication/exclude-filters.xml
Line 5:         This configuration is read only, and rather than performing an 
Line 6:         arrays copy, we prefer to ignore this warning
Line 7:        -->
Line 8:      <Match>
Line 9:        <Class 
name="org.ovirt.engine.core.authentication.kerberos..KerberosJaasConfiguration" 
/>
Not sure if findbugs will like the two dots before the class name.
Line 10:        <Method name="getAppConfigurationEntry"/>
Line 11:        <Bug code="RV"/>
Line 12:      </Match>


-- 
To view, visit http://gerrit.ovirt.org/21030
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4004e4a783530767b2f7682be17b3ce1e9a3802
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to