Alexander Wels has posted comments on this change.

Change subject: userportal, webadmin: ScrollableTabBar
......................................................................


Patch Set 5:

(2 comments)

....................................................
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/ScrollableTabBarView.java
Line 166:     private Widget copyWidget(final IsWidget widget) {
Line 167:         HTML newWidget = null;
Line 168:         if (widget != null) {
Line 169:             newWidget = new HTML();
Line 170: //            widget.asWidget().addStyleName(style.dropdownItems());
removed
Line 171:             // Align the text of the copy left, so it shows properly 
in the list.
Line 172: //            
widget.asWidget().getElement().getStyle().setProperty(TEXT_ALIGN, "left"); 
//$NON-NLS-1$
Line 173:             
newWidget.setHTML(widget.asWidget().getElement().getString().replaceAll("class=\".*?\"",
 //$NON-NLS-1$
Line 174:                     "class=\"" + style.dropdownItems() + "\"")); 
//$NON-NLS-1$ //$NON-NLS-2$


Line 181:                     adjustButtons();
Line 182:                 }
Line 183:             });
Line 184:             newWidget.addStyleName(style.dropdownItemContainer());
Line 185:             // Remove the extra styles from the original widget now 
that we have a copy of it.
removed
Line 186: //            
widget.asWidget().getElement().getStyle().clearProperty(TEXT_ALIGN);
Line 187: //            
widget.asWidget().removeStyleName(style.dropdownItems());
Line 188:         }
Line 189:         return newWidget;


-- 
To view, visit http://gerrit.ovirt.org/21716
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63dddb3c0026ea3a5c13c3d18daebd02e13b1043
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to