Moti Asayag has posted comments on this change. Change subject: engine: Extract common builder methods to base class ......................................................................
Patch Set 3: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworkParametersBuilder.java Line 63 Line 64 Line 65 Line 66 Line 67 that was also on my mind, but will do it in a future patch. basically, i think that the hierarchy of the classes should be a bit different and i'll modify them in that fashion which will allow to write a proper testing for these classes. -- To view, visit http://gerrit.ovirt.org/22889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia67531b028ef698d3f1dd98657ccb93e00b30415 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
