Moti Asayag has posted comments on this change.

Change subject: engine: Set action message properties
......................................................................


Patch Set 5:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/LabelNetworkCommand.java
Line 40:     }
Line 41: 
Line 42:     @Override
Line 43:     protected void setActionMessageParameters() {
Line 44:         addCanDoActionMessage(VdcBllMessages.VAR__TYPE__LABEL);
I reordered the patches so the LabelNetworkCommand could benefit of other 
refactor i did to the builder classes, however it looks like the definition of 
the label type couldn't be move forward as earlier patches depend on it.

I'll fix this issue.
Line 45:         addCanDoActionMessage(VdcBllMessages.VAR__ACTION__ADD);
Line 46:     }
Line 47: 
Line 48:     @Override


-- 
To view, visit http://gerrit.ovirt.org/22873
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa0fce0f7ebac3bb2cb48967d132d86441af11c0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to