Mike Kolesnik has posted comments on this change.
Change subject: engine: Update nics with user configuration
......................................................................
Patch Set 4:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 555: }
Line 556:
Line 557: VDSStatus returnStatus = vds.getStatus();
Line 558: NonOperationalReason nonOperationalReason =
Line 559:
CollectVdsNetworkDataVDSCommand.persistAndEnforceNetworkCompliance(vds, false,
null);
Since you call from here always with constant values (false and null) it is
more common to have a signature that accepts only the variable parameter and
internally calls with the constant parameters.
For example, you might want to change the parameters and not have this caller
affected only because you changed the constant parameters.
Line 560:
Line 561: if (nonOperationalReason != NonOperationalReason.NONE) {
Line 562: setIsSetNonOperationalExecuted(true);
Line 563:
--
To view, visit http://gerrit.ovirt.org/22871
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcb860cf638286c469ea032ffd0fa4291214bf77
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
