Ori Liel has posted comments on this change.
Change subject: restapi: add VmPayload support
......................................................................
Patch Set 6: (3 inline comments)
Small comments, we're virtually done. thanks
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
Line 77: return vm;
now that we've moved the code to populate, there's no reason to get the VM
reference. Can you change back to the way it was before?
Line 99: return retVal;
now that we've moved the code to populate, there's no reason to get the VM
reference. Can you change back to the way it was before?
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
Line 853: if (entity.getFile() != null) {
better entity.isSetFile()
--
To view, visit http://gerrit.ovirt.org/3460
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75d42a1963e537ff4e2f1fdd50ee7f2b427c6076
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
