Allon Mureinik has posted comments on this change.
Change subject: core: GetAllVmSnapshotsFromConfigurationByVmIdQuery
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
Giving -1 as this patch is unclear to me.
Let's discuss?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmSnapshotsFromConfigurationByVmIdQuery.java
Line 17: @Override
Line 18: protected void executeQueryCommand() {
Line 19: List<Snapshot> snapshots =
getDbFacade().getSnapshotDao().getAllWithConfiguration(getParameters().getId());
Line 20: for (Snapshot snapshot : snapshots) {
Line 21: this.snapshot = snapshot;
This doesn't make any sense to me.
Why should we loop and change the state of a member?
Line 22: VM vm =
getVmFromConfiguration(snapshot.getVmConfiguration());
Line 23: if (vm != null) {
Line 24: snapshot.setDiskImages(vm.getImages());
Line 25: }
--
To view, visit http://gerrit.ovirt.org/22774
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23aa4de4d233fade33d2a5ea174a9a1802b49370
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
