Moti Asayag has submitted this change and it was merged. Change subject: core: Set parameters task success only for command ......................................................................
core: Set parameters task success only for command Set the task success only for the commands that actually failed, by default tasks are considered to have ended all successfully. The success is an aggregation of the status of the command itself (would change if it also sent a task) and the status of all son commands, where if one failed then as a whole the parent is considered as failed. This will allow to selectively fail the parent command and all son commands that failed, while the son commands that have finished can clean up after themselves, instead of leaving garbage. This change will not harm current behavior, however, since the VmCommand will set the son commands to failed if the parent command has failed either way. Change-Id: I4366b6606ae83064b313aed17b4f65384e22342b Signed-off-by: Mike Kolesnik <mkole...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/SetTaskGroupStatusVisitor.java 3 files changed, 26 insertions(+), 25 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4366b6606ae83064b313aed17b4f65384e22342b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
