Moti Asayag has posted comments on this change. Change subject: core: Introduce NetworkLabel entity ......................................................................
Patch Set 5: (1 comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkLabel.java Line 1: package org.ovirt.engine.core.common.businessentities.network; Line 2: Line 3: import org.ovirt.engine.core.common.businessentities.IVdcQueryable; Line 4: Line 5: public class NetworkLabel extends IVdcQueryable { as explained in the commit message - this is not a real entity in the system. This class designed to allow speaking the same language with the rest which expects backend collections to inherit the IVdcQueryable. Having this class implementing BusinessEnitity isn't correct, cause there is no real value to it. Line 6: Line 7: private static final long serialVersionUID = -2906392515766833212L; Line 8: private String id; Line 9: -- To view, visit http://gerrit.ovirt.org/22802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28f4e7688a02cdc8bf0475dbd237e09352add2e3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches