Allon Mureinik has uploaded a new change for review.
Change subject: webadmin: Ignore FindBugs unconfirmed cast warning
......................................................................
webadmin: Ignore FindBugs unconfirmed cast warning
Ignore all the unconfirmed casts in the gwt-common, uicommonweb and
webadmin modules.
Unfortunately, these warnings are currently inherit to the design,
and handling them on an individual basis just adds noise to the
process.
Change-Id: I142db2592a9fe7b38a6751bcc362546ef46cc857
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M frontend/webadmin/modules/gwt-common/exclude-filters.xml
M frontend/webadmin/modules/uicommonweb/exclude-filters.xml
M frontend/webadmin/modules/webadmin/exclude-filters.xml
3 files changed, 23 insertions(+), 371 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/79/22879/1
diff --git a/frontend/webadmin/modules/gwt-common/exclude-filters.xml
b/frontend/webadmin/modules/gwt-common/exclude-filters.xml
index faffa3e..d3d4aa8 100644
--- a/frontend/webadmin/modules/gwt-common/exclude-filters.xml
+++ b/frontend/webadmin/modules/gwt-common/exclude-filters.xml
@@ -122,174 +122,13 @@
<Bug code="Nm"/>
</Match>
- <Match>
- <Class
name="org.ovirt.engine.ui.common.editor.AbstractUiCommonModelEditorDriver$1" />
+ <!--
+ Ignore all the unconfirmed casts in this module.
+ Unfortunately, these warnings are currently inherit to the design,
+ and handling them on an individual basis just adds noise to the
+ process.
+ -->
+ <Match>
<Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class name="org.ovirt.engine.ui.common.editor.UiCommonEditorVisitor$3"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.presenter.AbstractLoginPopupPresenterWidget$5"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.presenter.AbstractModelBoundPopupPresenterWidget$2"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.uicommon.model.ModelBoundPopupHandler$1" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.uicommon.model.ModelBoundPopupHandler$2" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.uicommon.model.SearchableTabModelProvider$1" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.uicommon.model.TabModelProvider$3" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class name="org.ovirt.engine.ui.common.widget.form.FormBuilder$1" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.view.popup.ForceRemoveConfirmationPopupView$1"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.view.popup.RemoveConfirmationPopupView$1" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.view.popup.RemoveConfirmationPopupView$2" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class name="org.ovirt.engine.ui.common.widget.TogglePanel$1" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class name="org.ovirt.engine.ui.common.widget.tab.ModelBoundTab$2" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget$17"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget$20"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget$23"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.presenter.AbstractSubTabPresenter$3" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.widget.uicommon.popup.pool.PoolNewPopupWidget$2"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.widget.uicommon.popup.vm.VmDiskPopupWidget$31"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.widget.uicommon.popup.vm.VmDiskPopupWidget$32"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.widget.uicommon.popup.vm.VmDiskPopupWidget$33"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.widget.uicommon.popup.vm.VmMakeTemplatePopupWidget$4"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.widget.uicommon.popup.vm.VmSnapshotCreatePopupWidget$1"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.widget.uicommon.vm.VmDiskListModelTable$9" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.widget.uicommon.storage.IscsiTargetToLunView$1"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.widget.uicommon.storage.IscsiDiscoverTargetsView$1"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.widget.uicommon.storage.SanStorageLunToTargetList$6"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.widget.uicommon.storage.AbstractSanStorageView$1"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.widget.uicommon.popup.networkinterface.NetworkInterfacePopupWidget$1"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.widget.uicommon.popup.vm.VmRunOncePopupWidget$13"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.widget.uicommon.storage.IscsiStorageView$1" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.common.uicommon.FrontendFailureEventListener" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class name="org.ovirt.engine.ui.common.uicommon.RdpPluginImpl" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- </FindBugsFilter>
+ </Match>
+</FindBugsFilter>
diff --git a/frontend/webadmin/modules/uicommonweb/exclude-filters.xml
b/frontend/webadmin/modules/uicommonweb/exclude-filters.xml
index 4392178..1386213 100644
--- a/frontend/webadmin/modules/uicommonweb/exclude-filters.xml
+++ b/frontend/webadmin/modules/uicommonweb/exclude-filters.xml
@@ -10,59 +10,13 @@
<Bug code="NP"/>
</Match>
- <Match>
- <Class name="org.ovirt.engine.ui.uicommonweb.models.EntityModel" />
+ <!--
+ Ignore all the unconfirmed casts in this module.
+ Unfortunately, these warnings are currently inherit to the design,
+ and handling them on an individual basis just adds noise to the
+ process.
+ -->
+ <Match>
<Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class name="org.ovirt.engine.ui.uicommonweb.models.ListModel" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.uicommonweb.models.hosts.HostInterfaceListModel" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.uicommonweb.models.providers.NeutronAgentModel$2" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.uicommonweb.models.storage.SanStorageModel$2" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.uicommonweb.models.vms.EditVmInterfaceModel" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.uicommonweb.models.vms.VmInterfaceModel" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class name="org.ovirt.engine.ui.uicommonweb.models.CommonModel" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.uicommonweb.models.hosts.AsyncIterator$1" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.uicommonweb.models.vms.ConsoleModelErrorEventListener"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.uicommonweb.models.vms.SpiceConsoleModel" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
+ </Match>
</FindBugsFilter>
diff --git a/frontend/webadmin/modules/webadmin/exclude-filters.xml
b/frontend/webadmin/modules/webadmin/exclude-filters.xml
index 3db1cbc..156e25d 100644
--- a/frontend/webadmin/modules/webadmin/exclude-filters.xml
+++ b/frontend/webadmin/modules/webadmin/exclude-filters.xml
@@ -251,154 +251,13 @@
<Bug code="UuF"/>
</Match>
+ <!--
+ Ignore all the unconfirmed casts in this module.
+ Unfortunately, these warnings are currently inherit to the design,
+ and handling them on an individual basis just adds noise to the
+ process.
+ -->
<Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.popup.host.SetupNetworksManagementPopupPresenterWidget$1"
/>
<Bug pattern="BC_UNCONFIRMED_CAST"/>
</Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.AssignTagsPopupView$1"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.configure.RolePopupView$5"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.datacenter.RecoveryStorageConfirmationPopupView$1"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.popup.host.HostPopupPresenterWidget$1"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.popup.host.HostPopupPresenterWidget$4"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.SearchPanelPresenterWidget$1"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.popup.AbstractNetworkPopupPresenterWidget$1"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.presenter.popup.cluster.ClusterPopupPresenterWidget$1"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.gluster.RemoveBrickPopupView$2"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.gluster.VolumePopupView$4"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.gluster.VolumeRebalanceStatusPopupView$9"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.guide.GuidePopupView$1"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class name="org.ovirt.engine.ui.webadmin.ApplicationConstants" />
- <Bug pattern="SKIPPED_CLASS_TOO_BIG"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.host.HostBondPopupView$3"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.host.HostInterfacePopupView$3"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.host.HostManagementPopupView$3"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.host.ManualFenceConfirmationPopupView$1"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.host.HostPopupView$8"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.host.HostPopupView$10"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.host.HostPopupView$17"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.profile.VnicProfilePopupView$3"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.quota.QuotaPopupView$15"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.user.ManageEventsPopupView$3"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.view.tab.gluster.SubTabVolumeGeneralView$1"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.uicommon.model.BookmarkModelProvider$5" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.uicommon.model.SimpleSelectionTreeNodeModel$1"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.widget.host.HostInterfaceForm$2" />
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.host.HostSetupNetworksPopupView$2"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
- <Match>
- <Class name="org.ovirt.engine.ui.webadmin.uicommon.WebAdminConfigurator"
/>
- <Bug pattern="BC_UNCONFIRMED_CAST"/>
- </Match>
-
</FindBugsFilter>
--
To view, visit http://gerrit.ovirt.org/22879
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I142db2592a9fe7b38a6751bcc362546ef46cc857
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
