Lior Vernia has posted comments on this change.

Change subject: webadmin: Added remove external subnet capability
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkExternalSubnetListModel.java
Line 16: import org.ovirt.engine.ui.uicompat.PropertyChangedEventArgs;
Line 17: 
Line 18: @SuppressWarnings("rawtypes")
Line 19: public class NetworkExternalSubnetListModel extends SearchableListModel
Line 20: {
When it comes to curly brackets I would follow the styling of the backend, I'm 
sure you have a link to that guide.
Line 21: 
Line 22:     private UICommand removeCommand;
Line 23: 
Line 24:     public NetworkExternalSubnetListModel() {


-- 
To view, visit http://gerrit.ovirt.org/22687
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib389ef5b94ee2176f4cf019540663cda3d337bd0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to