Lior Vernia has posted comments on this change.
Change subject: core: Added QoS overridden member to VdsNetworkInterface
......................................................................
Patch Set 4:
(1 comment)
I didn't see the harm in it. I saw it as something similar to what happens with
static IP nowadays, which can be changed on the host without taking the network
out of sync.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java
Line 328: this.networkImplementationDetails =
networkImplementationDetails;
Line 329: }
Line 330:
Line 331: /**
Line 332: * Gets the QoS configured on this interface, which overrides the
one possibly configured on the network.
Well, I figured if the engine is the only one configuring the host, then
there's no reason why it wouldn't be, unless the whole setup networks operation
failed (in which case I wouldn't expect the QoS configuration to have taken
effect either). And if it isn't, then it is not something we're supposed to
support well (just enable it).
Line 333: */
Line 334: public NetworkQoS getQos() {
Line 335: return qos;
Line 336: }
--
To view, visit http://gerrit.ovirt.org/22764
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaffc4c2f5b35ed34bf64e4d892a0e9ed64f94bde
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
