Alona Kaplan has posted comments on this change.

Change subject: webadmin: fix NPE in styles
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Hi, the problem was the style was used before the binder
initialized it.
The fix is to use the style after the initWidget.
The style is initialized in the AbstractLoginPopupView 
initWidget. So the is no need to override the setStyle in the sons.

I did the fix in commit http://gerrit.ovirt.org/#change,4158

--
To view, visit http://gerrit.ovirt.org/4158
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02cb2abf31028d5db3c46ecfbcaa6916da1e4f81
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to