Yedidyah Bar David has posted comments on this change. Change subject: core: Alert on log file opening failure ......................................................................
Patch Set 3: > 1. ignore exception if log cannot open log file. > 2. print warning at setup that log cannot be opened. Tried that. All debug output goes to terminal, and so is very inconvenient. Also had to change src/otopi/dialog.py:__setupStdHandles to not try fileno() if handle is None. I suggest: If log file can't be opened: try /tmp/something (mkstemp), and if it fails too try /dev/null, and if it fails too give up. If all of these fail, the system has some other serious problems and users will have to use OTOPI_DEBUG to get more info. Also keep the error while opening the requested/default log 2. output the error at setup What do you say? -- To view, visit http://gerrit.ovirt.org/22625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1da48cc50985a3d353964466f38babbbd42f4f3 Gerrit-PatchSet: 3 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
