Gilad Chaplik has posted comments on this change.

Change subject: common: adding Affinity Groups business entity
......................................................................


Patch Set 6:

(2 comments)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/AffinityGroup.java
Line 44:     /**
Line 45:      * list of entity uuids that are included in affinity group.<br>
Line 46:      * currently supported by vms
Line 47:      */
Line 48:     private List<Guid> entityIds;
in this stage only VM are supported. I prefer JIT design for now, don't know 
how it's going to evolve.
Line 49:     /**
Line 50:      * list of entity names that are included in affinity group<br>
Line 51:      * each item index matches to entityIds index,<br>
Line 52:      * i.e. entityNames.get(5) is the name of the entity with 
entityIds.get(5) id.


Line 67:     public void setId(Guid id) {
Line 68:         this.id = id;
Line 69:     }
Line 70: 
Line 71:     public String getName() {
I will add it in the next patch-set.
Done.
Line 72:         return name;
Line 73:     }
Line 74: 
Line 75:     public void setName(String name) {


-- 
To view, visit http://gerrit.ovirt.org/22547
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2be28b3a0aede953fcf09e1b6a8f8f99806d9fb5
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kobi Ianko <k...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to