Moti Asayag has posted comments on this change. Change subject: core: take shared lock on vds when refreshing host capabilities ......................................................................
Patch Set 3: (1 comment) .................................................... Commit Message Line 12: not be affected by this change, except for when removing storage pool - Line 13: in that case we take shared lock on the VDS. We lock the VDS when Line 14: removing storage pool in order to prevent it from changing its state Line 15: since we want to ensure it is in maintenance. Since refreshing host Line 16: capabilities won't change the state of the host, it is ok that it will Actually, the refresh host capabilities might change the host status to Non-operational, see backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java, line 570: vds.setStatus(VDSStatus.NonOperational); Line 17: be executed while removing the storage pool. Thus it is ok to take Line 18: shared lock when refreshing the host capabilities. Line 19: Line 20: Change-Id: I395e71d95a2642c4ea652ee6a62f494ea97bf96d -- To view, visit http://gerrit.ovirt.org/22641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I395e71d95a2642c4ea652ee6a62f494ea97bf96d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
