Juan Hernandez has posted comments on this change.

Change subject: restapi: Reload host after cluster update
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
Line 89: 
Line 90:                 // After changing the cluster with the specialized 
command we need to reload the entity, so that it
Line 91:                 // contains the new cluster id. If we don't do this 
the next command will think that we are trying
Line 92:                 // to change the cluster, and it will explicitly 
refuse to perform the update.
Line 93:                 entity = getEntity(hostResolver, true);
Yes, it does, that goes in the next patch set.
Line 94: 
Line 95:                 // Alternatively we could just change the cluster id 
of the entity, but this looks less reliable.
Line 96:                 // entity.setVdsGroupId(clusterId);
Line 97: 


-- 
To view, visit http://gerrit.ovirt.org/22739
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6470ad9ce07a3a5f68146d0b73b2f50ba508b0f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to