Arik Hadas has posted comments on this change.
Change subject: core: setting NIC boot order by NIC name
......................................................................
Patch Set 2:
(3 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
Line 163: return bootOrder;
Line 164: }
Line 165:
Line 166: private static List<VmDevice> getPluggedInterfaces(List<VmDevice>
devices) {
Line 167: ArrayList<VmDevice> result = new ArrayList<VmDevice>();
Done
Line 168: for (VmDevice device : devices) {
Line 169: if (isBridge(device) && device.getIsPlugged()) {
Line 170: result.add(device);
Line 171: }
Line 178: if (pluggedInterfaces.size() < 2) {
Line 179: return pluggedInterfaces;
Line 180: }
Line 181:
Line 182: final HashMap<Guid, String> deviceIdToIfaceName = new
HashMap<Guid, String>();
Done
Line 183: for (VmNetworkInterface iface : vm.getInterfaces()) {
Line 184: deviceIdToIfaceName.put(iface.getId(), iface.getName());
Line 185: }
Line 186:
Line 179: return pluggedInterfaces;
Line 180: }
Line 181:
Line 182: final HashMap<Guid, String> deviceIdToIfaceName = new
HashMap<Guid, String>();
Line 183: for (VmNetworkInterface iface : vm.getInterfaces()) {
Nice catch. so I changed it to fetch the network interfaces there, as we do for
the disks
Line 184: deviceIdToIfaceName.put(iface.getId(), iface.getName());
Line 185: }
Line 186:
Line 187: Collections.sort(pluggedInterfaces, new
Comparator<VmDevice>() {
--
To view, visit http://gerrit.ovirt.org/22560
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7916c3873361ef5bc4331ddfd3c60506f3c99fa3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
