Moti Asayag has posted comments on this change.
Change subject: engine: Add query for external subnets
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/ExternalSubnet.java
Line 33: }
Line 34:
Line 35: @Override
Line 36: public String getName() {
Line 37: return this.name;
"this" ?
Line 38: }
Line 39:
Line 40: public void setName(String value) {
Line 41: this.name = value;
Line 105: if (!(obj instanceof ExternalSubnet)) {
Line 106: return false;
Line 107: }
Line 108: ExternalSubnet other = (ExternalSubnet) obj;
Line 109: if (getCidr() == null) {
you can use ObjectUtils.objectsEqual() and simplify this method.
Line 110: if (other.getCidr() != null) {
Line 111: return false;
Line 112: }
Line 113: } else if (!getCidr().equals(other.getCidr())) {
--
To view, visit http://gerrit.ovirt.org/22684
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad328e86b62fad26b24f92d20c54ef1e4d0b207c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
