Eli Mesika has posted comments on this change. Change subject: db: Affinity Groups database support ......................................................................
Patch Set 1: (3 comments) .................................................... File packaging/dbscripts/affinity_groups_sp.sql Line 18: BEGIN Line 19: RETURN QUERY Line 20: SELECT * Line 21: FROM affinity_groups_view Line 22: WHERE cluster_id = v_cluster_id; Do you have an index on cluster_id ?? Line 23: END; $procedure$ Line 24: LANGUAGE plpgsql; Line 25: Line 26: -- get Affinity Group with members by id Line 74: END LOOP; Line 75: END; $procedure$ Line 76: LANGUAGE plpgsql; Line 77: Line 78: -- Delete Affinity Group (uses cascade to remove members) TWS Line 79: Create or replace FUNCTION DeleteAffinityGroup(v_id UUID) Line 80: RETURNS VOID Line 81: AS $procedure$ Line 82: BEGIN .................................................... File packaging/dbscripts/upgrade/03_04_0300_create_affinity_group_tables.sql Line 1: CREATE OR REPLACE FUNCTION __temp_Upgrade_AddAffinityGroupsTables() Line 2: RETURNS void Line 3: AS $function$ Line 4: BEGIN Line 5: IF EXISTS (SELECT * FROM information_schema.tables WHERE table_name ILIKE 'affinity_groups') THEN please remove the whole SP envelope and leave only the "Create Table" statement since this script will not attempt to run twice (this is managed by the db upgrade mechanism) Line 6: RETURN; Line 7: END IF; Line 8: -- create affinity_groups table Line 9: CREATE TABLE affinity_groups -- To view, visit http://gerrit.ovirt.org/22714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib09c50cae8d9a23a08a9e723d0e0498ea2016e6a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
