Mike Kolesnik has posted comments on this change.
Change subject: core: handle nic ordering when adding or importing a VM
......................................................................
Patch Set 8:
(2 comments)
Basically +2 only a couple small comments
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 1061: // If we import it as a new entity, then we allocate all MAC
addresses in advance
Line 1062: if (getParameters().isImportAsNewEntity()) {
Line 1063: List<String> macAddresses =
MacPoolManager.getInstance().allocateMacAddresses(nics.size());
Line 1064: for (int i = 0; i < nics.size(); ++i) {
Line 1065: VmNetworkInterface iface = nics.get(i);
This variable can be inlined, i.e.
nics.get(i).setMacAddress(macAddresses.get(i));
Line 1066: iface.setMacAddress(macAddresses.get(i));
Line 1067: }
Line 1068: }
Line 1069:
Line 1066: iface.setMacAddress(macAddresses.get(i));
Line 1067: }
Line 1068: }
Line 1069:
Line 1070: for (int i = 0; i < nics.size(); ++i) {
No need for change since you dont need i anymore
Line 1071: VmNetworkInterface iface = nics.get(i);
Line 1072: initInterface(iface);
Line 1073: vnicProfileHelper.updateNicWithVnicProfileForUser(iface,
getCurrentUser());
Line 1074:
--
To view, visit http://gerrit.ovirt.org/22411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b4ffc4ecaab824b90bf8b8ecdfe4ebad3074bf
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
