Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup:correct parameter for method
inst_update_service_type
......................................................................
Patch Set 1:
(1 comment)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/appmode.py
Line 114: %(gluster)s
Line 115: )
Line 116: """,
Line 117: args=dict(
Line 118: cluster_ID,
why not modify the inst_update_service_type to do that internally?
Anyway, this is not going to work as the return value is array of dicts.
And it wont work as you should specify cluster_ID=cluster_Id, to have proper
dictionary.
And... do not use execute statement but getVdcOption().
And please do not use temp variables....
dict(
clusterId=...getVdcOption(),
),
Line 119: virt=(v in ('both', 'virt')),
Line 120: gluster=(v == 'gluster'),
Line 121: ),
Line 122: )
--
To view, visit http://gerrit.ovirt.org/22650
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34bebf502b94f69701ec5b68bd5497ff68a4a143
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnara...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
