Yair Zaslavsky has posted comments on this change.
Change subject: oVirt Node Upgrade: Support N configuration
......................................................................
Patch Set 20:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java
Line 85:
Line 86: boolean shouldAdd = false;
Line 87: RpmVersion isoVersion = new
RpmVersion(file.getName());
Line 88:
Line 89: String rpmParts[] =
RpmVersionUtils.splitRpmToParts(file.getName());
Hi douglas, where is "rpmParts" being used?
Line 90: if (isoData.getVdsmCompatibilityVersion() !=
null) {
Line 91: shouldAdd =
isIsoCompatibleForUpgradeByClusterVersion(isoData);
Line 92: } else if (vdsOsVersion != null) {
Line 93: if
(VdsHandler.isIsoVersionCompatibleForUpgrade(vdsOsVersion, isoVersion)) {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeInfo.java
Line 31: return instance;
Line 32: }
Line 33:
Line 34: private OVirtNodeInfo() {
Line 35: final String delimiter = ":";
Hi, Sorry for not noticing before, out of curiosity - why are you using the ":"
delimiter and not that the "," ?
In addition, why not move the delimeter to be a private static final field?
Line 36: final String[] path =
Config.resolveOVirtISOsRepositoryPath().split(delimiter);
Line 37: final String minimumVersion[] = Config.<String>
GetValue(ConfigValues.OvirtInitialSupportedIsoVersion).split(delimiter);
Line 38:
Line 39: // Node prefix is part of regex to list ISOs (OvirtIsoPrefix)
--
To view, visit http://gerrit.ovirt.org/14756
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfb9dc5d0dc8780b519107acbe0ae866831f782c
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Michael Burns <mbu...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
