Juan Hernandez has posted comments on this change.

Change subject: restapi: NPE on new VM
......................................................................


Patch Set 1:

I have been trying to reproduce this in master and I haven't been able: 
creating the VM works correctly.

The reason for this difference between the 3.3 branch and master may be one of 
these two changes:

  http://gerrit.ovirt.org/20763 - Update to Jacson 1.9.9
  http://gerrit.ovirt.org/20704 - Add support for JAXB annotations in JSON

I think that the second is probably what makes it work in master. Note that 
till this change was introduced the JSON support was experimental only, we will 
hopefully start to support it in 3.4.

In addition adding default values in the .xsd means that the API is partially 
dictating the logic to the backend, which is something we try to avoid if 
possible.

I would appreciate if you can check if applying change 20704 to the 3.3 branch 
solves the issue.

-- 
To view, visit http://gerrit.ovirt.org/22593
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9cbc0634f2bb8a0c80efb40f1db4a0a904d2ac2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to