Lior Vernia has uploaded a new change for review.

Change subject: webadmin: Unify VLAN and MTU styles
......................................................................

webadmin: Unify VLAN and MTU styles

No reason to have two identical styles, especially when these two
fields should looks the same.

Change-Id: Ied923a1cbfcd3cfeefdf154d31554e5693baddca
Signed-off-by: Lior Vernia <lver...@redhat.com>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml
2 files changed, 4 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/06/22606/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
index 9cf6068..63a1dc3 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
@@ -210,8 +210,8 @@
     }
 
    protected void addStyles() {
-        vlanTag.addContentWidgetStyleName(style.vlanEditor());
-        mtuEditor.addContentWidgetStyleName(style.mtuEditor());
+        vlanTag.addContentWidgetStyleName(style.valueBox());
+        mtuEditor.addContentWidgetStyleName(style.valueBox());
         isVmNetworkEditor.addContentWidgetStyleName(style.checkBox());
         isVmNetworkEditor.asCheckBox().addStyleName(style.checkBox());
         vlanTagging.addContentWidgetStyleName(style.checkBox());
@@ -383,9 +383,7 @@
     }
 
     interface WidgetStyle extends CssResource {
-        String mtuEditor();
-
-        String vlanEditor();
+        String valueBox();
 
         String checkBox();
     }
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml
index c62dfd1..ad4a2d8 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml
@@ -32,12 +32,8 @@
                        padding-left: 10px;
                }
 
-               .mtuEditor {
+               .valueBox {
                        width: 100px;
-               }
-
-               .vlanEditor {
-                       width:100px;
                }
 
                .checkBox {


-- 
To view, visit http://gerrit.ovirt.org/22606
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied923a1cbfcd3cfeefdf154d31554e5693baddca
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to