Ramesh N has posted comments on this change.
Change subject: webadmin: update hash name for remove brick status
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
Line 579: final ConfirmationModel cModel = new ConfirmationModel();
Line 580: final GlusterVolumeEntity volumeEntity =
(GlusterVolumeEntity) getSelectedItem();
Line 581: setConfirmWindow(cModel);
Line 582:
cModel.setTitle(ConstantsManager.getInstance().getConstants().rebalanceStatusTitle());
Line 583:
cModel.startProgress(ConstantsManager.getInstance().getConstants().rebalanceStatusFetchMessage());//$NON-NLS-1$
Similar thing I have added in remove brick status also. I thought this dialog
will be displayed until status dialog opens and hence make sense to add it
here. So either we should remove from both the places or we should keep it in
both the places. What is your suggestion
Line 584: cModel.setHashName("volume_rebalance_status"); //$NON-NLS-1$
Line 585:
Line 586: final UICommand rebalanceStatusOk = new
UICommand("rebalanceNotStarted", VolumeListModel.this);//$NON-NLS-1$
Line 587:
rebalanceStatusOk.setTitle(ConstantsManager.getInstance().getConstants().ok());
--
To view, visit http://gerrit.ovirt.org/22578
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7b359a9a0f9c004b1ab6b654d77bd28a08027c6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
