Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: simplify exports and overide by env ......................................................................
Patch Set 3: (5 comments) .................................................... File packaging/setup/ovirt_engine_setup/constants.py Line 924 Line 925 Line 926 Line 927 Line 928 why not in post install? why not summary? Line 927: Line 928: @osetupattrs( Line 929: answerfile=True, Line 930: ) Line 931: def ISO_DOMAIN_NFS_CLIENTS(self): ACL or any other term that exists in man? Line 932: return 'OVESETUP_CONFIG/isoDomainClients' Line 933: Line 934: @osetupattrs( Line 935: answerfile=True, .................................................... File packaging/setup/plugins/ovirt-engine-setup/system/exportfs.py Line 147: ) Line 148: ) Line 149: if conf_index is None: Line 150: if self._conf == osetupcons.FileLocations.NFS_EXPORT_FILE: Line 151: content = conf_content + [new_line] append or extend Line 152: exports_uninstall_group.addChanges( Line 153: group='exportfs', Line 154: filename=self._conf, Line 155: changes=[ Line 158: } Line 159: ], Line 160: ) Line 161: else: Line 162: content = [new_line] short trivial clause first. Line 163: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 164: filetransaction.FileTransaction( Line 165: name=self._conf, Line 166: content=content, Line 175: ), Line 176: after=( Line 177: osetupcons.Stages.DIALOG_TITLES_S_SUMMARY, Line 178: ), Line 179: condition=lambda self: self._enabled, add post install message of how to change the setting in future so we can manage the conf.d always? Line 180: ) Line 181: def _closeup(self): Line 182: rc, stdout, stderr = self.execute( Line 183: ( -- To view, visit http://gerrit.ovirt.org/22557 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If63bb5395f0bf78c8fb61942a7a7c236eedad17b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
