Juan Hernandez has posted comments on this change. Change subject: sdk: Use the same httplient in SDK and generator ......................................................................
Patch Set 1: (1 comment) .................................................... File ovirt-engine-sdk-java-codegen/pom.xml Line 33: <dependency> Line 34: <groupId>org.apache.httpcomponents</groupId> Line 35: <artifactId>httpclient</artifactId> Line 36: <version>4.2</version> Line 37: <scope>compile</scope> Some of the classes in codegen import classes from httpclient, in particular they import org.apache.http.client.ClientProtocolException, so the dependency is still needed. But looking at this deeper I think that we can use IOException instead of ClientProtocolException, and that will remove the need for the dependency. I am checking. Line 38: </dependency> Line 39: <dependency> Line 40: <groupId>commons-beanutils</groupId> Line 41: <artifactId>commons-beanutils</artifactId> -- To view, visit http://gerrit.ovirt.org/22439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10259c434282bdafb077393a5db193ae7a7ce0da Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
