Michael Pasternak has posted comments on this change. Change subject: sdk: The code generator needs to depend on the SDK ......................................................................
Patch Set 2: Verified+1 Code-Review+2 (1 comment) .................................................... File ovirt-engine-sdk-java-codegen/pom.xml Line 23: <groupId>org.ovirt.engine.sdk</groupId> Line 24: <artifactId>ovirt-engine-sdk-java</artifactId> Line 25: <version>1.0.0.18-1</version> Line 26: </dependency> Line 27: <dependency> Hi Juan, i'm intentionally didn't had sdk as strict dependency so it will always use the latest one locally, but in general you're right, we can rely on specific version as used sdk functionality by codegen, does not require having latest artifacts. Line 28: <groupId>junit</groupId> Line 29: <artifactId>junit</artifactId> Line 30: <version>3.8.1</version> Line 31: <scope>test</scope> -- To view, visit http://gerrit.ovirt.org/22437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia699e673546e360e4535a7bd4678c08fd37e18d4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
