Hello Alex Lourie,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/22550
to review the following change.
Change subject: packaging: setup: update error handling in remote DB flow
......................................................................
packaging: setup: update error handling in remote DB flow
Change-Id: I60af89aee018eb44a63d38de42f2643c0d850d3e
Bug-Url: https://bugzilla.redhat.com/1039946
Signed-off-by: Alex Lourie <alou...@redhat.com>
---
M packaging/ovirt-engine-reports-setup.py
1 file changed, 2 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-reports refs/changes/50/22550/1
diff --git a/packaging/ovirt-engine-reports-setup.py
b/packaging/ovirt-engine-reports-setup.py
index 8b95c73..ae55915 100755
--- a/packaging/ovirt-engine-reports-setup.py
+++ b/packaging/ovirt-engine-reports-setup.py
@@ -1086,7 +1086,7 @@
)
if not DB_EXIST:
print (
- 'error: cannot connect to the '
+ 'Error: cannot connect to the '
'remote db with provided credentials. '
'verify that the provided user is defined '
'user exists on a remote db server and '
@@ -1094,10 +1094,7 @@
'Then rerun the setup.\n'
)
if options['REMOTE_DB_HOST'] is not None:
- sys.exit(1)
-
- else:
- raise RuntimeError('Could not connect to the remote DB')
+ raise RuntimeError('Could not connect to the
remote DB')
if not isWarInstalled() and DB_EXIST and dblocal:
@utils.transactionDisplay('Checking system state')
--
To view, visit http://gerrit.ovirt.org/22550
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I60af89aee018eb44a63d38de42f2643c0d850d3e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Yaniv Dary <yd...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
