Martin Peřina has posted comments on this change. Change subject: tools: Adds config validation prior to notifier service startup ......................................................................
Patch Set 1: Alon, if you don't believe me, try it for yourself: 1) Edit /usr/share/ovirt-engine/services/ovirt-engine-notifier/ovirt-engine-notifier.py and sys.exit(1) as first command in main 2) Execute systemctl start ovirt-engine-notifier For service types other then forking, the exit code is ignored while starting service -- To view, visit http://gerrit.ovirt.org/22530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I524e952f9e6a93002426ad3e828ca8300672e762 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
