Michael Pasternak has posted comments on this change. Change subject: restapi: add support to regenerate ids when adding vm from configuration ......................................................................
Patch Set 2: >>> the user might have predefined scripts that make use of >>> the id and he'll want to use the same one. he also might >>> want to add a different vm with the same configuration >>> but different ids from that exact reason. this is entirely wrong, using this logic we allowing user telling us what the id of the vm should be... our IDs are opaque and we may change them whenever we find right as it not a part of the api, but as i mentioned only internal implementation detail. -- To view, visit http://gerrit.ovirt.org/22207 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ccf0f61b58ad49aa50d1efe3aa0b9a8bd31da70 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juana Garcia <garciajuan...@gmail.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
