Roy Golan has posted comments on this change.
Change subject: core, webadmin, restapi: Fix VM creation with blank template
......................................................................
Patch Set 6: Code-Review+2
(2 comments)
minor comments
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java
Line 309: private Map<DisplayType, VmDeviceType> parseDisplayProtocols(int
osId, Version version) {
Line 310: Map<DisplayType, VmDeviceType> parseDisplayProtocols = new
HashMap<DisplayType, VmDeviceType>();
Line 311:
Line 312: String displayProtocolValue =
getValueByVersion(idToUnameLookup.get(osId), "displayProtocols", version);
Line 313: for (String displayProtocol :
displayProtocolValue.split(",")) {
use the trimElements(list)
Line 314: Pair<String, String> pairs =
parseDisplayProtocol(displayProtocol);
Line 315: if (pairs != null) {
Line 316:
parseDisplayProtocols.put(DisplayType.valueOf(pairs.getFirst()),
Line 317: VmDeviceType.getByName(pairs.getSecond()));
Line 503: }
Line 504:
Line 505: @Override
Line 506: public Map<ArchitectureType, Integer> getDefaultOSes() {
Line 507: HashMap<ArchitectureType, Integer> defaultOSes = new
HashMap<ArchitectureType, Integer>();
please cache this map (as it is hard coded) and create an intial value so it
would be compact
new HashMap<>(2)
Line 508:
Line 509: defaultOSes.put(ArchitectureType.x86_64, DEFAULT_X86_OS);
Line 510: defaultOSes.put(ArchitectureType.ppc64, DEFAULT_PPC_OS);
Line 511:
--
To view, visit http://gerrit.ovirt.org/20667
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I880e5940c7244476e477e098445a47210ea08b5d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
