Yedidyah Bar David has posted comments on this change. Change subject: packaging: osinfo: move sysprep defaults out of /etc ......................................................................
Patch Set 3: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/legacy/osinfo.py Line 45: @plugin.event( Line 46: stage=plugin.Stages.STAGE_MISC, Line 47: condition=lambda self: self.environment[ Line 48: osetupcons.CoreEnv.ACTION Line 49: ] == osetupcons.Const.ACTION_UPGRADE, If you intend to keep this module also in 3.4, for people upgrading e.g. from 3.3.2, it better be put elsewhere, perhaps plugins/ovirt-engine-setup/upgrade . Or change http://gerrit.ovirt.org/22149 to not delete all of legacy... but I thought "legacy" is 3.2. Line 50: after=[ Line 51: osetupcons.Stages.DB_CONNECTION_AVAILABLE, Line 52: ], Line 53: ) -- To view, visit http://gerrit.ovirt.org/22384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26a853c12ca091f340d6ebed2c10726462ec576a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
