Juan Hernandez has posted comments on this change. Change subject: restapi: Allow enabling/disabling SSO ......................................................................
Patch Set 3: (1 comment) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml Line 75: vm.description: xs:string Line 76: vm.comment: xs:string Line 77: vm.stateless: xs:boolean Line 78: vm.delete_protected: xs:boolean Line 79: vm.sso.methods.method: --COLLECTION: {method: 'xs:string'} I think that this syntax isn't correct, the --COLLECTION should go immediately after the name of the parameter, something like this: vm.sso.methods.method--COLLECTION: {method: 'xs:string'} However I'm not 100% sure, I'm checking. Can you check it yourself as well? Line 80: vm.console.enabled: xs:boolean Line 81: vm.cpu.topology.sockets: xs:int Line 82: vm.placement_policy.affinity: xs:string Line 83: vm.placement_policy.host.id|name: xs:string -- To view, visit http://gerrit.ovirt.org/21911 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25bf94646ea89684152e48f25ad604db6e59e86c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches