Liran Zelkha has posted comments on this change.
Change subject: engine: SearchQuery generates slow query on vds_with_tags and
storage_domains
......................................................................
Patch Set 9:
(1 comment)
....................................................
File
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
Line 892: String tableName =
mSearchObjectAC.getRelatedTableName(searchObjStr);
Line 893: String tableNameWithOutTags =
mSearchObjectAC.getRelatedTableNameWithOutTags(searchObjStr);
Line 894:
Line 895: boolean generalQuery = false;
Line 896: String innerQuery;
No, it's the other way around. We need to know if someone is querying on the
tag. If he does - we go with the regular flow. Otherwise we go with the
optimized flow, which is not the default flow in the system. Changing the
default flow is much harder, and breaks many pieces of the code :-(
Line 897: if (!wherePhrase.toString().contains("tag_name")
Line 898: && !wherePhrase.toString().contains(".")
Line 899: &&
(searchObjStr.equals(SearchObjects.VDS_OBJ_NAME) ||
searchObjStr.equals(SearchObjects.VDC_STORAGE_DOMAIN_OBJ_NAME))) {
Line 900: innerQuery =
--
To view, visit http://gerrit.ovirt.org/20914
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0b7a4912d031c4cdafd636126730ea81d8d2bdd
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
