Martin Peřina has posted comments on this change. Change subject: core: Add proxy agent support verification ......................................................................
Patch Set 2: Code-Review+1 (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java Line 281: private VDS getFenceProxy(final boolean onlyUpHost, final boolean filterSelf, final PMProxyOptions proxyOptions) { Line 282: List<VDS> hosts = DbFacade.getInstance().getVdsDao().getAll(); Line 283: VDS proxyHost = LinqUtils.firstOrNull(hosts, new Predicate<VDS>() { Line 284: @Override Line 285: public boolean eval(VDS vds) { Could be simplified even more ... Line 286: if (!isAgentSupported(vds)) { Line 287: return false; Line 288: } Line 289: if (proxyOptions == PMProxyOptions.CLUSTER) { -- To view, visit http://gerrit.ovirt.org/22423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e6610e1e7be660c894c879288d9df9b0956eda5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches