Kanagaraj M has posted comments on this change. Change subject: webadmin,userportal: Improve TextBoxLabelBase ......................................................................
Patch Set 1: Code-Review+2 (1 comment) .................................................... Commit Message Line 32: using Renderer<? super T> instead of just Renderer<T> Line 33: at runtime. Line 34: Line 35: (Makes me wonder why GWT ValueBoxBase doesn't work Line 36: with Renderer<? super T> just like GWT ValueLabel.) Agree with you. Thanks a lot for the detailed explanation. Now i got why Parser can(should) be contravariance. Line 37: Line 38: Change-Id: Ie691685ec6e9e1830da1457a0747901ba833be5d -- To view, visit http://gerrit.ovirt.org/22236 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie691685ec6e9e1830da1457a0747901ba833be5d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
