Sandro Bonazzola has posted comments on this change. Change subject: packaging: use service infra from ovirt-engine-lib ......................................................................
Patch Set 1: (3 comments) .................................................... File packaging/services/ovirt-engine-dwhd/__init__.py Line 1: # Copyright 2012 Red Hat 2013, also in other files Line 2: # Line 3: # Licensed under the Apache License, Version 2.0 (the "License"); Line 4: # you may not use this file except in compliance with the License. Line 5: # You may obtain a copy of the License at .................................................... File packaging/services/ovirt-engine-dwhd/ovirt-engine-dwhd.sysv.in Line 1: #!/bin/sh Line 2: # Line 3: # Start/stop oVirt Engine Dataware House Line 4: # Line 5: # chkconfig: - 65 34 have you checked 65 / 34 against postgres? Line 6: # description: oVirt Engine Dataware House Line 7: # pidfile: /var/run/ovirt-engine-dwhd.pid Line 8: Line 9: ### BEGIN INIT INFO Line 7: # pidfile: /var/run/ovirt-engine-dwhd.pid Line 8: Line 9: ### BEGIN INIT INFO Line 10: # Provides: ovirt-engine-dwhd Line 11: # Short-Description: oVirt Engine Dataware House Any reason for dropping Required-Start and Required-Stop? Line 12: ### END INIT INFO Line 13: Line 14: # Source function library. Line 15: . /etc/rc.d/init.d/functions -- To view, visit http://gerrit.ovirt.org/22445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic506d6962f8ccfc9bb7538484aee2867491d8b20 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches