Yedidyah Bar David has posted comments on this change.

Change subject: packaging: setup: Allow static IP on the host
......................................................................


Patch Set 2:

> No, we don't have code for disabling NetworkManager. It should be handled by 
> VDSM. However, if it's not handled by vdsm and we need it to be stopped for 
> having static IP, I don't think we need another bz.

I installed Fedora 19 twice:
1. On a VM (created by virt-install on Debian) - 
/etc/sysconfig/network-scripts/ifcfg-* file was created. I already destroyed 
the machine so I do not have exact details, but it had 'bootproto=dhcp'.

2. On a mini Dell box. 'ip addr' shows an interface called 'em1', but in 
/etc/sysconfig/network-scripts I have a file 'ifcfg-eno1' with 'NAME="eno1"' in 
it, and the MAC address of em1 (as in 'ip addr'). I admit NetworkManager is 
currently beyond me.

I suggest to merge this change and ask for more testing later, including 
playing with NetworkManager.

-- 
To view, visit http://gerrit.ovirt.org/22399
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I108c2202ebed0e90a7d06cfdef1bce8154cfd3fb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to