Moti Asayag has uploaded a new change for review.

Change subject: restapi: Reduce parent visibility
......................................................................

restapi: Reduce parent visibility

The visibility of BackendDataCenterNetworkResource.parent
can be reduced to private. In addition, some cleanup to
alignment to java naming convention.

Change-Id: Ica3c54be916ea4c0c3df70170b508f35ae7376d2
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterNetworkResource.java
1 file changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/42/22442/1

diff --git 
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterNetworkResource.java
 
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterNetworkResource.java
index be65230..4192d29 100644
--- 
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterNetworkResource.java
+++ 
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterNetworkResource.java
@@ -1,28 +1,29 @@
 package org.ovirt.engine.api.restapi.resource;
 
 import java.util.List;
+
 import org.ovirt.engine.api.model.Network;
 
 public class BackendDataCenterNetworkResource extends BackendNetworkResource {
 
-    BackendDataCenterNetworksResource _parent;
+    private BackendDataCenterNetworksResource parent;
 
     public BackendDataCenterNetworkResource(String id, 
BackendDataCenterNetworksResource parent) {
         super(id, parent);
-        this._parent = parent;
+        this.parent = parent;
     }
 
     @Override
     public Network get() {
-        org.ovirt.engine.core.common.businessentities.network.Network entity = 
getNetworks();
+        org.ovirt.engine.core.common.businessentities.network.Network entity = 
getNetwork();
         if (entity == null) {
             return notFound();
         }
         return addLinks(map(entity));
     }
 
-    private org.ovirt.engine.core.common.businessentities.network.Network 
getNetworks() {
-        List<org.ovirt.engine.core.common.businessentities.network.Network> 
networks = _parent.getNetworks();
+    private org.ovirt.engine.core.common.businessentities.network.Network 
getNetwork() {
+        List<org.ovirt.engine.core.common.businessentities.network.Network> 
networks = parent.getNetworks();
         for (org.ovirt.engine.core.common.businessentities.network.Network 
entity : networks) {
             if (entity.getId().toString().equals(id)) {
                 return entity;
@@ -33,6 +34,6 @@
 
     @Override
     public BackendDataCenterNetworksResource getParent() {
-        return _parent;
+        return parent;
     }
 }


-- 
To view, visit http://gerrit.ovirt.org/22442
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica3c54be916ea4c0c3df70170b508f35ae7376d2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to