Roy Golan has posted comments on this change.
Change subject: core, engine: Get CD interface through osinfo
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
minor comments please update
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 718: struct.put(VdsProperties.Shareable, Boolean.FALSE.toString());
Line 719: }
Line 720:
Line 721: private static void addCdDetails(VmDevice vmDevice, Map<String,
Object> struct, VM vm) {
Line 722: OsRepository osRepository =
SimpleDependecyInjector.getInstance().get(OsRepository.class);
use getOsRepository()
Line 723:
Line 724: struct.put(VdsProperties.Type, vmDevice.getType().getValue());
Line 725: struct.put(VdsProperties.Device, vmDevice.getDevice());
Line 726:
....................................................
File packaging/conf/osinfo-ppc64.properties
this file doesn't exist. other_ppc64 has been merged into
osinfo-defaults.propertis. please rebaseu
--
To view, visit http://gerrit.ovirt.org/20294
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I579fdcc0b6bdf7d23bd60efc33fbc4bad1595324
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
