Alissa Bonas has posted comments on this change.
Change subject: engine: Fixed redundant null check find bug error
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
-1 so it won't be mistakenly merged.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 448:
Line 449: private boolean hostUuidExists(Guid addedServerUuid) {
Line 450: GlusterServerDao glusterServerDao =
DbFacade.getInstance().getGlusterServerDao();
Line 451: GlusterServer glusterServer =
glusterServerDao.getByGlusterServerUuid(addedServerUuid);
Line 452: if (glusterServer == null ||
glusterServer.getId().equals(getVds().getId())) {
Did you verify that the findbugs warning is indeed resolved?
Because IMHO this code change does not solve it.
The warning is about redundant check against null, and here it still exists.
Please see the description:
http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/5967/findbugsResult/new/source.11791/#442
Line 453: return false;
Line 454: }
Line 455: return true;
Line 456: }
--
To view, visit http://gerrit.ovirt.org/22405
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9652c52e2886a4c225b5a79985f18f7f372dd4e4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
