Allon Mureinik has posted comments on this change.

Change subject: core,webadmin: Plug disk to VM when adding a new disk
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 865: ACTION_TYPE_FAILED_GUEST_OS_VERSION_IS_NOT_SUPPORTED=Cannot ${action} 
${type}. Guest OS version is not supported.
Line 866: HOT_PLUG_DISK_IS_NOT_VIRTIO=Can plug only virtIO disks.
Line 867: HOT_PLUG_DISK_IS_NOT_UNPLUGGED=Disk is already activated.
Line 868: HOT_UNPLUG_DISK_IS_NOT_PLUGGED=Disk is already deactivated.
Line 869: CANNOT_ADD_FLOATING_DISK_WITH_PLUG_VM_SET=Cannot ${action} ${type}. A 
disk configured with the "Plug disk to VM" setting cannot be created as a 
floating disk.
Looks good to me, please make sure the quotes don't break anything.
Line 870: ACTIVATE_DEACTIVATE_NIC_VM_STATUS_ILLEGAL=Cannot activate/deactivate 
VM Network Interface due to VM status. The VM status must be Down or Up.
Line 871: ACTIVATE_DEACTIVATE_NETWORK_NOT_IN_VDS=The Network does not exist on 
the host the VM is running on.\n Either add the Network to the Host or migrate 
the VM to a Host that has this Network.
Line 872: VM_CANNOT_RUN_FROM_DISK_WITHOUT_PLUGGED_DISK=Cannot ${action} ${type} 
without at least one active disk.\nPlease activate a disk and rerun the VM.
Line 873: SHAREABLE_DISK_IS_NOT_SUPPORTED_FOR_DISK=Cannot ${action} ${type}. 
Disk cannot be shareable if it depends on a snapshot. In order to share it, 
remove the disk's snapshots.


-- 
To view, visit http://gerrit.ovirt.org/21851
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9778bcaf21b346a55992590159cabd8d78f0c66
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to