Yedidyah Bar David has posted comments on this change.

Change subject: packaging: setup: remove legacy support (3.2)
......................................................................


Patch Set 3:

(1 comment)

....................................................
File packaging/setup/plugins/ovirt-engine-setup/core/misc.py
Line 64:             os.path.exists(
Line 65:                 
osetupcons.FileLocations.OVIRT_SETUP_POST_INSTALL_CONFIG
Line 66:             ) and
Line 67:             os.path.exists(
Line 68:                 
osetupcons.FileLocations.OVIRT_ENGINE_PKI_ENGINE_CA_CERT
I do not mind it that much - just wanted to preserve existing behavior. 
Currently not having ca implies it's a new setup. It's not that the definition 
of 'setup' vs 'upgrade' is so sharp and clear, anyway.
Line 69:             )
Line 70:         ):
Line 71:             self.environment[
Line 72:                 osetupcons.CoreEnv.ACTION


-- 
To view, visit http://gerrit.ovirt.org/22149
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a798929fb5c831ca46900da6caa1b03a2600555
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to