Alon Bar-Lev has posted comments on this change. Change subject: packaging: Build pyc/pyo files ......................................................................
Patch Set 3: (1 comment) .................................................... File Makefile Line 406: # legacy-end Line 407: Line 408: compile-python-files: Line 409: $(PYTHON) -m compileall -f -q -d / "$(DESTDIR)" Line 410: $(PYTHON) -O -m compileall -f -q -d / "$(DESTDIR)" hmmm.... doing make install will try to compile all root fs... and DESTDIR may be empty. I suggest doing so at spec file at %install, As other distributions has other method of compiling python, even for multiple versions of python. For example at Gentoo the pythonlib will be compiled for 2.7, 3.1, 3.2 versions of python. Line 411: Line 412: gwt-debug: Line 413: [ -n "$(DEBUG_MODULE)" ] || ( echo "Please specify DEBUG_MODULE" && false ) Line 414: cd "frontend/webadmin/modules/$(DEBUG_MODULE)" && \ -- To view, visit http://gerrit.ovirt.org/22342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4098fb7f8f664e6c1df678717c8ee230a3113fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
