Juan Hernandez has posted comments on this change.
Change subject: core, restapi: Add DbGroup
......................................................................
Patch Set 20:
(5 comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainGroupResource.java
Line 7: import org.ovirt.engine.core.common.queries.DirectoryIdQueryParameters;
Line 8: import org.ovirt.engine.core.common.queries.VdcQueryType;
Line 9:
Line 10: /**
Line 11: * This resource corresponds to a user that exists in some directory
accessible by the engine, and that may or may not
Done
Line 12: * have been added to the engine and stored in the database. This
resource doesn't provide information about the
Line 13: * permissions, roles or tags of the group, even if those have been
already assigned and stored in the database.
Line 14: */
Line 15: public class BackendDomainGroupResource
Line 33:
Line 34: @Override
Line 35: public Group get() {
Line 36: DirectoryIdQueryParameters queryParameters = new
DirectoryIdQueryParameters(
Line 37: parent.getDirectory().getName(),
The unique identifier of a directory entry is the pair (directoryName,
directoryId) thus the query requires both parameters. Note that the directoryId
is the identifier assigned by the directory, not the identifier assigned by the
engine. This resource manages groups that may not have been added yet to the
engine data base, so it has to use the identifier assigned by the directory,
not the identifier assigned by the engine.
Line 38: guid
Line 39: );
Line 40: return performGet(VdcQueryType.GetDirectoryGroupById,
queryParameters, BaseResource.class);
Line 41: }
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDomainGroupsResource.java
Line 48: public DomainGroupResource getDomainGroupSubResource(String id) {
Line 49: return inject(new BackendDomainGroupResource(id, this));
Line 50: }
Line 51:
Line 52: private String getSearchPattern() {
Will try to do so.
Line 53: String constraint = QueryHelper.getConstraint(
Line 54: getUriInfo(),
Line 55: LdapGroup.class,
Line 56: false
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceTest.java
Line 202
Line 203
Line 204
Line 205
Line 206
Done. I will restore it in the next patch set.
Line 232
Line 233
Line 234
Line 235
Line 236
Done. I will restore it in the next patch set.
--
To view, visit http://gerrit.ovirt.org/17544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb1a7146c29eb74f97e10043d65b5a67f1430021
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
