Alon Bar-Lev has posted comments on this change.
Change subject: webadmin: Remove dependency on VdcQuery and Action parameters
base
......................................................................
Patch Set 7:
(2 comments)
....................................................
File
frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/utils/Parameter_CustomFieldSerializer.java
Line 11: public class Parameter_CustomFieldSerializer {
Line 12:
Line 13: public static Parameter instantiate(SerializationStreamReader
reader) throws SerializationException {
Line 14: UUID uuid = UUID_CustomFieldSerializer.instantiate(reader);
Line 15: return Parameter.getByUuid(uuid.toString());
no reason for the uuid temp parameter :)
Line 16: }
Line 17:
Line 18: public static void serialize(SerializationStreamWriter writer,
Parameter instance) throws SerializationException {
Line 19: UUID_CustomFieldSerializer.serialize(writer,
instance.getUuid());
Line 18: public static void serialize(SerializationStreamWriter writer,
Parameter instance) throws SerializationException {
Line 19: UUID_CustomFieldSerializer.serialize(writer,
instance.getUuid());
Line 20: }
Line 21:
Line 22: public static void deserialize(SerializationStreamReader reader,
Parameter instance) throws SerializationException {
I guess we do not serialize as the parameter instance contains the values?
Line 23: }
Line 24:
--
To view, visit http://gerrit.ovirt.org/21482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32eede1e6a27bfe4d906be1fe0a3a397a865df4c
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
