Yair Zaslavsky has posted comments on this change. Change subject: core(wip): remove null check at executeReadList ......................................................................
Patch Set 2: Code-Review+2 (1 comment) .................................................... Commit Message Line 7: core(wip): remove null check at executeReadList Line 8: Line 9: I think that the null validation at executeReadList should be re examined Line 10: for the following reasons: Line 11: 1) We already sets the key RETURN_VALUE at createCallForRead before each s/sets/set Line 12: call, when creating the SimpleJdbcCall. Line 13: 2) Until now executeRead called executeReadList and did not checked if Line 14: the returned list is null or not. Line 15: -- To view, visit http://gerrit.ovirt.org/19818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54f25002701bcaa6e82a572b6fa5ed8ffa5e043a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
