Liron Ar has posted comments on this change. Change subject: core: allow deactivate storage domain in different statuses ......................................................................
Patch Set 2: @Allon - There are few reasons for this change - i'll give 2 examples here to clarify why it's needed: 1.if domain is in inactive status, it can mean that it's either not accessible or that our repoStats report for it isn't within the defined boundaries (for example - slow access) - there's absolutely no need to disallow us to activate in this situation, what the user shall do to deactivate? speed up his connection so that the domain will move active and then deactivate it? :) 2.Currently there is a bug in ActivateStorageDomain command, which i've handled in http://gerrit.ovirt.org/#/c/22347/ The main issue here that if you fail to execute ActivateStorageDomainVDSCommand, you shouldn't return the domain to maintenance as you don't know if it was activated in vdsm or not - after this issue is resolved by having the domain status changed to unknown instead of return to maintenance in case that the request was possibly submitted, in case that the domain wasn't activated in vdsm, it won't be reported by the host's repoStats and will move to the status inactive in the engine. At this stage, the user won't be able to move it maintenance without activating although nothing was changed on vdsm side - therefore we should allow to attempt to deactivate in this change or before the domain is inactive (during the 5 minutes that it's "unknown"). to sum up, i think that we'll gain only benefits from allowing it. -- To view, visit http://gerrit.ovirt.org/22348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc131262c70f687a3ba73b40999d00ded9acfe97 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
